Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision differences in test/level01/pflotran_stor #252

Open
millerta opened this issue Jan 2, 2024 · 1 comment
Open

Precision differences in test/level01/pflotran_stor #252

millerta opened this issue Jan 2, 2024 · 1 comment

Comments

@millerta
Copy link
Collaborator

millerta commented Jan 2, 2024

New mac compilers handle floats differently resulting in precision differences for very small values.
This caused one of the tests to fail and it was commented out for level01 tests
and moved to test/level03/stor_precision_diff

For "degenerate" cases with 4 vertices on circumscribed circle, you can put the diagonal edge of the rectangle on either diagonal and round off may be the deciding factor. Different connection of degenerate case is still correct/Delaunay.

Possible fixes:
change test to avoid square, make vertical length shorter than horiz
or perhaps there is a flag fix for the mac compiler

NOTE files written without zero coefs are the same:
output_mac/out_hex_3x4.uge output_linux/out_hex_3x4.uge

linux and new mac:

<  -4.166666666667E-02 -1.515940605973E-17
---
>  -4.166666666667E-02 -4.618806972100E-17 -1.671098990551E-17
@millerta millerta added this to the Release V3.4.0 milestone Jan 2, 2024
@millerta
Copy link
Collaborator Author

Note the macports compilers do not have this issue. The stor test results are the same on mac and linux.
Compiled with sonoma on mac laptop:
export CC=/opt/local/bin/gcc-mp-12
export CXX=/opt/local/bin/g++-mp-12
export FC=/opt/local/bin/gfortran-mp-12

Issue Example in test/level03/stor_precision_diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant