Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Using Lucene 8? #3628

Open
nicenemo opened this issue Sep 27, 2020 · 5 comments
Open

Question: Using Lucene 8? #3628

nicenemo opened this issue Sep 27, 2020 · 5 comments

Comments

@nicenemo
Copy link

Any plans in using a more modern Lucene version, like version 8?

According to Elastic (known from ElasticSearch) later Lucene versions perform better. I tried building with Lucene 8 and 6.0.0. Both gave compile errors with Java 8.

@danielnaber
Copy link
Member

No plans yet, as we use some low-level stuff (e.g. at https://github.com/languagetool-org/languagetool/blob/1ed565ff6297c3e4e978057b92d66ea891486136/languagetool-wikipedia/src/main/java/org/languagetool/dev/index/LanguageToolFilter.java) that I found difficult to port to the new version when I last tried. PRs are very welcome, though.

@nicenemo
Copy link
Author

nicenemo commented Sep 27, 2020

I am Interested in using it in combination with GraalVM native.
Assuming I have ported the code. To proceed and get the tests running I have to recreate the ngrams and their lucene representation with the newer Lucene library first?

@danielnaber
Copy link
Member

Sorry for the late reply. I don't think the ngram will need to be re-created, I think the indexes can be converter to the latest Lucene (maybe step by step from one version of Lucene to the next).

@miurahr
Copy link
Contributor

miurahr commented Aug 6, 2024

No plans yet, as we use some low-level stuff (e.g. at https://github.com/languagetool-org/languagetool/blob/1ed565ff6297c3e4e978057b92d66ea891486136/languagetool-wikipedia/src/main/java/org/languagetool/dev/index/LanguageToolFilter.java) that I found difficult to port to the new version when I last tried. PRs are very welcome, though.

I would like to work with Lucene 8.11.3, that is latest library support Java 8, and update for ngram data, etc. and send you PR when completed.

There are three component that use Lucene; langaugetool-dev, languagetool-core and languagetool-wikipedia.
@danielnaber

@miurahr
Copy link
Contributor

miurahr commented Aug 30, 2024

Hi, I have also upgrade ngram data, and now it works well for me.
Please check #10810 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants