Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to log into steam #16

Closed
asdfmonster261 opened this issue Oct 10, 2024 · 6 comments · Fixed by #17
Closed

Failed to log into steam #16

asdfmonster261 opened this issue Oct 10, 2024 · 6 comments · Fixed by #17

Comments

@asdfmonster261
Copy link

asdfmonster261 commented Oct 10, 2024

Starting today I am getting this error in the logs. I've tried using it on two different networks and three machines with the same results. I am able to log into steamcmd anonymously on all machines.

[modules.steam] INFO: Log in to Steam
[modules.steam] INFO: Invoke anonymous login
[modules.steam] ERROR: Failed to log in to Steam
[modules.steam] ERROR: Failed to log in to Steam
[modules.steam] INFO: Log out from Steam
[__main__] INFO: Will sleep 300 seconds
@kurokobo
Copy link
Owner

Thanks for the report, will test on my side.

@kurokobo
Copy link
Owner

ValvePython/steam#474

@denizkoekden
Copy link

denizkoekden commented Oct 12, 2024

I dont know if this gets fixes ASAP because the Maintainers of the ValvePython/steam Project didn't do anything since 2 years. You can implement the wsproto-Branch from njbooher (https://github.com/njbooher/steam/tree/wsproto) and then add the following to the Project:

to requirements.txt add:

https://github.com/njbooher/steam/archive/wsproto.zip

wsproto

and then in helper/app_finder.py:

from steam.core.connection import WebsocketConnection as import here

from steam.client import SteamClient # noqa: E402

and then after here

_client.anonymous_login()
put

_client.connection = WebsocketConnection()

and it should work again as it is now using WebSocket instead of TCP for connecting to Steam.

@kurokobo
Copy link
Owner

@denizkoekden
Thanks, I already saw your comments on the issue and the related PR to support WS, and I also saw that the maintainer has been inactive lately😢 I'm going to take a quick look and see whether I should use the PR branch directly.

@denizkoekden
Copy link

The root of the problem is that the Steam Connection Manager is flaky (https://steamstat.us/) and I guess they prefer Websocket over TCP for now. My "solution" is only meant to fix it temporarly and I hope one of the maintainers will implement Websockets ASAP. I mentioned the most active maintainer in the PR.

@kurokobo
Copy link
Owner

It seems that the issue on Steam's side has been resolved, as the code that stopped working few weeks ago is now functioning again 🤔

That said, the dependencies have become outdated, so I think I will just update them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants