Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+C does not stop docker pull when dojo action is: run #1

Open
xmik opened this issue Feb 5, 2019 · 0 comments · May be fixed by #15
Open

Ctrl+C does not stop docker pull when dojo action is: run #1

xmik opened this issue Feb 5, 2019 · 0 comments · May be fixed by #15
Labels
bug Something isn't working low-priority

Comments

@xmik
Copy link
Member

xmik commented Feb 5, 2019

Dojo reacts on signals.

When we use Dojo action: pull, the docker pull command is run in the same process group as dojo process and thus Ctrl+C signal sent to dojo process is also sent to docker pull process.

However, when we use Dojo action: run, the docker run command is run in a new process group. Ctrl+C signal sent to dojo process is not sent to docker run process, but Dojo recognizes the signal and takes steps to stop the container(s) and to perform cleanup. Those steps (among other things) check if a container(s) was ever created. If it was created, dojo stops the container. If it was not yet created, dojo thinks there is no container process to stop and just waits for the main to exit. But there is docker pull process running and thus main does not exit fast.

@tomzo tomzo added bug Something isn't working low-priority labels Dec 23, 2019
xmik pushed a commit that referenced this issue Feb 13, 2022
than if running Docker on Linux or using Docker Desktop on Mac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants