-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VSC native problems on files with same name #73
Comments
This is related to a feature in SARIF where you have a How to fix? We attempted to fix this by taking a SARIF generated by Monokle and manually added the object originalUriBaseIds object with values fitting for our local computer. At that point, it no longer tries to attempt to guess the right file and it properly can allocate problems even if multiple have the same file name.
The SARIF spec talks more about this topic of the presence and absence of this property. Often it's desired to omit it due to privacy concerns (user name leaks) and non-determinism (different content hashes). The solution, is for the Monokle Validator to be configurable, and optionally, include this information in the response. We need to determine how to do this properly for each operating system (Windows, Linux, MacOS). AppendixFor MacOS it looks like this, in which case
|
It seems to be same on Windows, some refs: Might be related also to kubeshop/monokle-core#448. |
It was mostly fixed by kubeshop/monokle-core#588 and #75. However, one issue still remains. Repro steps:
When file is reopened it works fine. Seems like SARIF is not processing initially opened files. When we debugged initial issue, there is an array storing file references which is propagated when file is opened. And then if there is no match it will try to find a file based on filename - if the filename is not unique across a project this fails. What I suspect is that initially opened files are not added to mentioned file array (unless reopened) and files with no distinct name cannot be matched then and highlighting cannot be applied. |
Reproduction
The text was updated successfully, but these errors were encountered: