Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PriorityClass #322

Open
Bezbran opened this issue Oct 31, 2023 · 1 comment
Open

Use PriorityClass #322

Bezbran opened this issue Oct 31, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Bezbran
Copy link
Contributor

Bezbran commented Oct 31, 2023

Overview

Kubernetes offers a feature called PriorityClass which empowers cluster operators to determine the relative priority of pods. For our setup, pods such as the node-agent daemonset and kube-vuln should inherently possess a higher priority compared to other application pods.

Issue

Currently, the absence of a defined PriorityClass for our pods results in certain pods (like node-agent, kube-vuln, etc.) lingering in the "Pending" state. This persists until a cluster operator intervenes by manually deleting pods from nodes.

Proposed Solution

We should leverage PriorityClasses to address this:

  • system-node-critical: This should be assigned to node-agent pods, ensuring they run on every node without exception.

  • system-cluster-critical: This is apt for the remaining pods (operator, kubescape, kube-vuln, etc.) as they are essential for maintaining the cluster's health.

@Bezbran Bezbran added good first issue Good for newcomers enhancement New feature or request labels Oct 31, 2023
@tchatzig
Copy link

tchatzig commented Mar 5, 2024

It would be nice to be able to set up the priorityclass on the helm chart values.

like this chart for example
https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/values.yaml#L890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants