Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update security warning for custom indexes #615

Closed
chriskim06 opened this issue Jun 22, 2020 · 2 comments · Fixed by #616
Closed

Update security warning for custom indexes #615

chriskim06 opened this issue Jun 22, 2020 · 2 comments · Fixed by #616
Labels
area/multi-index

Comments

@chriskim06
Copy link
Member

chriskim06 commented Jun 22, 2020 •
edited
Loading

Right now a security warning is printed anytime a plugin is installed/upgrade. This should be changed in the case of custom indexes to:

  • the warning should be printed when the index is added
  • plugin install/upgrade should only print the warning if the plugin is from the default index

Related to: #576

/area multi-index
@chriskim06 chriskim06 changed the title Update security warning to Update security warning for custom indexes Jun 22, 2020
@ahmetb
Copy link
Member

ahmetb commented Jun 22, 2020

I recall our discussion was to perhaps move the warning to the index add and do not print for non-default indexes. My memory doesn't serve me well what we decided here.

@chriskim06
Copy link
Member Author

Ah ok, I was probably misremembering. I can update this issue description to reflect that.

This was referenced Jun 23, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/multi-index
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Print security notice when index is added chriskim06/krew
3 participants
@ahmetb @chriskim06 @k8s-ci-robot