Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Ownerreferences no longer added to resources deployed through operator #460

Open
HumairAK opened this issue Nov 24, 2020 · 2 comments
Open

Comments

@HumairAK
Copy link

HumairAK commented Nov 24, 2020

Hello, it seems this feature was initially added here but was later removed here in exchange for annotations. I also can't seem to find why this was changed. We found ownerreferences useful because we use ArgoCD to deploy our kfdefs and ArgoCD uses owner-references to draw out relationships (and possibly other logic) between the resources being deployed by the operator. Now Argocd only sees the kfdef and none of the components' resources being deployed. e.g.

image
vs:
image

Is this something that can be re-added?

@HumairAK
Copy link
Author

@animeshsingh @vpavlin

@tumido
Copy link

tumido commented Nov 24, 2020

I think the reason why it's been removed it is pretty much described in the PR (parent to the removal commit you linked, @HumairAK): #411.

It all leads to this upstream kubernetes issue kubernetes/kubernetes#65200 which will be fixed in kubernetes 1.20)

We use OCP, and I have no idea if the problem is actually present on our platform at all or not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants