Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the support to install event sources #298

Closed
houshengbo opened this issue Oct 6, 2020 · 9 comments · Fixed by #645
Closed

Add the support to install event sources #298

houshengbo opened this issue Oct 6, 2020 · 9 comments · Fixed by #645

Comments

@houshengbo
Copy link
Contributor

Problem
We cannot install any event resource available in https://github.com/knative/eventing-contrib.
Install the event sources available in the repo eventing-contrib. Make the CR able to configure the list of event sources, to be installed in the knative eventing.
The custom resource will look like this:

apiVersion: operator.knative.dev/v1alpha1
kind: KnativeEventing
metadata:
  name: knative-eventing
  namespace: knative-eventing
spec:
  event-contrib:
    version: 0.12.1
    sources: github,kafka

We can use a comma separated string to specify all the event sources to be installed. Or use the following CR

apiVersion: operator.knative.dev/v1alpha1
kind: KnativeEventing
metadata:
  name: knative-eventing
  namespace: knative-eventing
spec:
  event-contrib:
    version: 0.12.1
    sources:
      - github
      - kafka

Persona:
Which persona is this feature for?
Administrators.

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.

@houshengbo
Copy link
Contributor Author

We used to have a discussion on this feature: knative/eventing-operator#92

@matzew
Copy link
Member

matzew commented Oct 6, 2020

How does that relate to: #206 ??

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2021
@github-actions github-actions bot closed this as completed Feb 5, 2021
@houshengbo
Copy link
Contributor Author

/reopen

@knative-prow-robot
Copy link
Contributor

@houshengbo: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@houshengbo
Copy link
Contributor Author

We can leverage the same model in knative serving CR, defining the ingress, to install an eventing source:

apiVersion: operator.knative.dev/v1alpha1
kind: KnativeEventing
metadata:
  name: knative-eventing
  namespace: knative-eventing
spec:
  version: "0.22"
  eventingSource:
    github:
      enabled: true
      multiTenant: true

The field multiTenant: true is used to determine it is single or multi tenant. This field is available for github and kafkasource.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 13, 2021
@houshengbo
Copy link
Contributor Author

@evankanderson @maximilien
As we run into the issue of kustomize not recognizing the variable reference like !!merge <<: *openAPIV3Schema, it takes much effort for the operator to add the eventing source label, before saving the manifests under kodata. We decide to use a one source one directory approach to lower the bar of the implementation in operator.

The directory will be like:
Screen Shot 2021-05-05 at 8 49 59 AM

@vaikas
Copy link

vaikas commented May 28, 2021

I think @antoineco might be interested in this as well and might have some ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants