-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared pointer should be used where appropriate #988
Comments
@veloman-yunkan @mgautierfr Reading #991 (review), it seems to me there is a discrepency between both of you on (1) the nature of the problem (2) the path to follow to improve the situation. I have no optinion at all, but I would prefer to have you reaching a kind of of agreement on these two points before continuing PR implementation. |
Here a proposition:
|
I am fine with that |
See kiwix/kiwix-android#3467
The text was updated successfully, but these errors were encountered: