Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aria2 wrapper and Downloader thread safe/compliant. #873

Closed
mgautierfr opened this issue Jan 25, 2023 · 1 comment · Fixed by #886
Closed

Make aria2 wrapper and Downloader thread safe/compliant. #873

mgautierfr opened this issue Jan 25, 2023 · 1 comment · Fixed by #886
Assignees
Milestone

Comments

@mgautierfr
Copy link
Member

See kiwix/kiwix-desktop#87 (comment)

aria2 wrapper use a lock to prevent concurrent access to the curl handle. This create a bottleneck as we can do only one request at the time. If one request takes time (and starting a download does on window) all other requests are delayed (and blocked).

We should make aria2 wrapper thread compliant and also make Downloader thread safe to allow a real multi thread usage of Downloader

(Not sure we need to make Download threadsafe. We can simple state that methods on one Download are not threadsafe)

@kelson42 kelson42 added this to the 12.1.0 milestone Jan 25, 2023
@kelson42
Copy link
Collaborator

Seems pretty urgent if we want that kiwix/kiwix-desktop#87 works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants