-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement table of content #42
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
The strategy here is:
|
@kelson42 Hi. i saw this issue before opening my own. the fact that this thread is 4 years old without any progress in sight compelled me to make a fresh one. i would like to just clarify here that wikipedia zims already contain the ToCs and Templates(nav boxes). it's just that the kiwix-desktop application is unable to show them.
|
@knowledge-is-power Just to be clear, the ToC is not in the Wikipedia archives (not even hidden) so it needs to be constructed dynamically from the headers in the article. This isn't too hard, and some work was done on it in this PR, but then stalled. Reader software can implement a generic ToC if an article has H1, H2, H3 etc., but it's probably best done inside the ZIM. Navboxes, etc., are another matter. These are mostly in the Wikipedia ZIMs, but are hidden by the mobile style, so have to be force-unhidden (unless desktop CSS can be applied). |
@Jaifroid Ah, I see. thanks for the clarification. my main concern is actually the navboxes (which are very imp for extended exploration). so, will there be any work done towards force-unhiding or getting desktop css in kiwix-desktop application? |
@knowledge-is-power Just so you're aware, Kiwix JS isn't just a PWA, we also have installable packages for various platforms, and packages for Linux as well as Windows. See http://kiwix.github.io/kiwix-js-windows/kiwix-js-electron.html. Although it's not the full-featured Desktop app, it works very well with Wikimedia archives (and many others too). It's good to have options! |
Reminder: please one topic per ticket, here you mixed two topics which have nothing in common:
For the rest, the way forward is pretty known, we just need to have the development resources. It's an old problem, but this is on the roadmap and this will be fixed/implemented at some point. |
@kelson42 yeah I thought both issues were part of the same problem that's why I made a single ticket, sorry about that. now that its clear to me that they are unrelated, is it okay if i open a dedicated ticket for wiki navboxes/templates? (cuz this ticket is dedicated to ToC issue) |
|
@kelson42 Javascript Injection works fine. QWebEngineScript allows us to inject Javascript in separate files and we can also write the CSS styles over there. I can create a Mock up and you can advise on how to adjust the presentation (This is injected so it will feel foreign and we need a balance). |
@ShaopengLin So, far too late, but here is the mockup: You don't have to implement all the refinements of this mockup (search, back/forth buttons, indicator of localisation in the page), but it has to be as a sidebar and clean. I will open dedicated issues to be done later for the rest. |
Just jumping in to say .. I was really disappointed in the lack of TOCs, but have discovered that there is at least one chrome/firefox extension which generates them dynamically from page content, and it seems to work nicely with kiwix-serve: https://github.com/FallenMax/smart-toc I'm sure there are others, still looking .. |
This is a really old feature request, for Kiwix Desktop 1.0 too.
See this old ticket: https://sourceforge.net/p/kiwix/feature-requests/1000/
The text was updated successfully, but these errors were encountered: