You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug #5293 removed metadata format specific implementations of the SchemaConverterInterface. That left XMLSchemaConverter.java as the only schema converter currently available. The class contains a check for "supported source metadata formats". That check was originally meant to enable catalog configurations in kitodo_opac.xml for specific metadata formats like MODS or MARCXML without explicitly configuring special mapping files. These configurations would instead use default mapping files for those formats when no mappingFiles element was found in a catalog configuration in kitodo_opac.xml.
#5038 replaced the configurations in kitodo_opac.xml with the new ImportConfiguration class. Mapping files with specific metadata input and output formats are now mandatory with this class, so the case described above cannot occur anymore. The check for supported metadata formats is already done when saving the import configuration itself and falsely prevents catalog configurations without mappingFiles element in kitodo_opac.xml to be converted to new ImportConfiguration instances with the error message Missing mandatory XML element "mappingFiles"
Instead, the check for the mappingFiles element during the conversion of kitodo_opac.xml entries to new ImportConfiguration instances should add default mapping files instead of leading to an conversion error.
To Reproduce
Steps to reproduce the behavior:
Convert a kitodo_opac.xml configuration file that contains a catalog configuration without mappingFiles element
The conversion will fail with the error message Mandatory configuration "mappingFiles" is missing
Expected behavior
The conversion should add default mapping files to catalog configurations in kitodo_opac.xml that do not contain a mappingFiles element instead of
Describe the bug
#5293 removed metadata format specific implementations of the
SchemaConverterInterface
. That leftXMLSchemaConverter.java
as the only schema converter currently available. The class contains a check for "supported source metadata formats". That check was originally meant to enable catalog configurations inkitodo_opac.xml
for specific metadata formats like MODS or MARCXML without explicitly configuring special mapping files. These configurations would instead use default mapping files for those formats when nomappingFiles
element was found in a catalog configuration inkitodo_opac.xml
.#5038 replaced the configurations in
kitodo_opac.xml
with the newImportConfiguration
class. Mapping files with specific metadata input and output formats are now mandatory with this class, so the case described above cannot occur anymore. The check for supported metadata formats is already done when saving the import configuration itself and falsely prevents catalog configurations withoutmappingFiles
element inkitodo_opac.xml
to be converted to newImportConfiguration
instances with the error messageMissing mandatory XML element "mappingFiles"
Instead, the check for the
mappingFiles
element during the conversion ofkitodo_opac.xml
entries to newImportConfiguration
instances should add default mapping files instead of leading to an conversion error.To Reproduce
Steps to reproduce the behavior:
kitodo_opac.xml
configuration file that contains a catalog configuration withoutmappingFiles
elementMandatory configuration "mappingFiles" is missing
Expected behavior
The conversion should add default mapping files to catalog configurations in
kitodo_opac.xml
that do not contain amappingFiles
element instead ofRelease
3.4.4-SNAPSHOT (Commit b65bd96)
The text was updated successfully, but these errors were encountered: