Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata with multiple options not saved without preset #4061

Open
solth opened this issue Oct 23, 2020 · 3 comments
Open

Metadata with multiple options not saved without preset #4061

solth opened this issue Oct 23, 2020 · 3 comments
Labels
bug ruleset ruleset functions and configuration

Comments

@solth
Copy link
Member

solth commented Oct 23, 2020

Metadata defined by a key with multiple options in the ruleset (resulting in a pulldown/selectOne menu) is can only be saved in the metadata editor if a preset is configured.

Metadata configured the following way can be saved:

<key id="metadata1">
	<label>Works</label>
	<option value="value1"/>
	<option value="value2"/>
	<option value="value3"/>
	<preset>value1</preset>
</key>

Metadata configured the following way cannot be saved:

<key id="metadata2">
	<label>Broken</label>
	<option value="value1"/>
	<option value="value2"/>
	<option value="value3"/>
</key>
@matthias-ronge
Copy link
Collaborator

matthias-ronge commented Oct 27, 2020

I have now tested this with the ruleset_test.xml, which you made available to me yesterday, using the metadata LegalNoteAndTermsOfUse, which doesn’t declare a <preset>, on division "Volume".

  • with minOccurs="1" and maxOccurs="1", multiline="false" is saved is not saved
  • with maxOccurs="1", multiline="false" is saved
  • with minOccurs="1", multiline="false" is saved
  • unbounded, multiline="false" is saved
  • unbounded, multiline="false" with alwaysShowing="true" is saved
  • unbounded, multiline="true" with alwaysShowing="true" (list of checkboxes) is not savedAlways showing multi-select metadata is not saved  #4068
  • with maxOccurs="1", multiline="true" (list of radio buttons) is not savedMulti-line single-select metadata is not saved #4069
  • with maxOccurs="1", without any <setting> (drop-down select) is saved
  • with minOccurs="1" and maxOccurs="1", without any <setting> (drop-down select) is saved.

Summary: Pull-down seems to work for me, but there are saving issues here.

@matthias-ronge
Copy link
Collaborator

Just to be sure, I also tested with "metadata2" as you indicated above (no <label> elements), but it also saves.

@matthias-ronge
Copy link
Collaborator

matthias-ronge commented Feb 19, 2021

Today I encounter the situation that with build of 37d56a0 the constellation minOccurs="1" and maxOccurs="1" is not saved, neither with explicit multiline="false" nor without <setting> at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ruleset ruleset functions and configuration
Projects
None yet
Development

No branches or pull requests

2 participants