Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar cannot be saved #3722

Closed
matthias-ronge opened this issue Jun 4, 2020 · 5 comments
Closed

Calendar cannot be saved #3722

matthias-ronge opened this issue Jun 4, 2020 · 5 comments

Comments

@matthias-ronge
Copy link
Collaborator

matthias-ronge commented Jun 4, 2020

In version 2, the calendar can be downloaded and uploaded again in another session. You don't have to do all the editing at once. In addition, the (scripted) creation of the XML file offers further options for importing calendar data. The function no longer exists.

Screenshot from version 2

Goal: It is cumbersome to download the file locally and upload it again. But saving should be possible.

@henning-gerhardt
Copy link
Collaborator

henning-gerhardt commented Jun 4, 2020

Please do not store this calendar data on server side. This would need a lot more logic behind (serving data, update data, remove data, user access, permissions to this data, permissions for users to interact with this data, ...)

@matthias-ronge
Copy link
Collaborator Author

My idea is to save a publication-history.xml in the newspaper's process directory. The calendar editor would then have the same buttons as the metadata editor: cancel, save, save and close. There is exactly one publication history per newspaper. Perhaps you can then later use the publication-history.xml to insert editions into the newspaper afterwards, which is still an unimplemented feature, but a desiration.

@henning-gerhardt
Copy link
Collaborator

henning-gerhardt commented Jun 5, 2020

Please keep in your mind that

  • not every "newspaper" is a newspaper
  • not every newspaper has a regular publication course
  • not every newspaper starts and ends in a year, like season publications from August to July next year and then from September to July the next year after (f.e. xx.08.1900 - xx.07.1901 and xx.09.1901 - xx.07.1902)
  • and maybe many more things which I forget now

@matthias-ronge
Copy link
Collaborator Author

matthias-ronge commented Jun 8, 2020

That is all correct, but has nothing to do with the problem here. The issue is that you cannot interrupt the editing of the appearance history and continue later. The format of course.xml (as existing in Production 2) supports any irregular publication course. (In fact, it a kind of list of issue dates and does not store the abstract “course”. The “course” is re-calculated from the list of issues on load.) It also supports setting a year begin different from 1st of January. All of this functionality is already implemented and no bugs have been reported on it. The thing that is missing, is that the save and load is not executed in Production 3.

@matthias-ronge
Copy link
Collaborator Author

Completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants