Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaving pages unstructured needs always a retry of the moving action in the structure tree #3476

Closed
subhhwendt opened this issue Apr 17, 2020 · 5 comments
Labels

Comments

@subhhwendt
Copy link
Collaborator

Step 1
grafik

Result makes unhappy regarding page numbering…..
grafik

Step 2: You can correct in the structure tree!
First try fails

grafik

Second try is ok - and it remains ok after saving the process
grafik

@solth
Copy link
Member

solth commented Apr 17, 2020

Result makes unhappy regarding page numbering…..

Thanks for the very specific and useful problem description 😝

If I understand you correctly, the missing option Create element here (or something like that, e.g. "at the same place of the selected pages") is what makes you unhappy, right? If there is not already a feature request ticket for this, we should add one.

Given the current - probably insufficient - options to add new elements at specific locations, the re-numbering of the pages assigned to the newly created structural element seems correct, though. Since the Titelblatt was added as the first child of the Monographie, it was inserted before original pages 1 and 2 and all pages were re-numbered accordingly.

The actual bug in this issue seems to be the two tries required to succesfully move the created structural element. Is that correct?

@subhhwendt
Copy link
Collaborator Author

Sorry for my next mismatch in writing tickets -I tried to fulfill your requirement for a complete view for a problem.
I confirm that the actual bug refer to the two tries required for the intended move.

@matthias-ronge
Copy link
Collaborator

matthias-ronge commented Nov 3, 2020

It looks like this is partly the problem described in #4038. @subhhwendt, what is shown in the structure tree, is not the pagination, but an internal command number. That is confusing. That's what I described in the other ticket. (In your example, the pagination is "-" for all images).

A second (and independent) problem, if I understand correctly, is that the newly created division appears just below the parent node, and the unassigned images with a smaller number after it; they should appear before it. There shouldn't be a new function for this, it should always happen that way.

Wrong: (the numbers here indicate the image number, assuming #4038 is fixed)

📁 Monograph
   📁 Title page
      🖼️ 4
      🖼️ 3
   🖼️ 1
   🖼️ 2
   🖼️ 5
   🖼️ 6
   …

Correct:

📁 Monograph
   🖼️ 1
   🖼️ 2
   📁 Title page
      🖼️ 4
      🖼️ 3
   🖼️ 5
   🖼️ 6
   …

Goal: I would suggest focusing this ticket on the second problem and solving the numbering display problem with the other ticket.

@solth
Copy link
Member

solth commented Apr 6, 2021

@subhhwendt Can you confirm that the actual bug reported in this issue - e.g. two drag'n'drop actions are required to move a new structure element - still occurs? I just tested this with the current master and the structure element - including its assigned pages - was successfully moved on the first try.

@subhhwendt
Copy link
Collaborator Author

I confirm - there's no bug!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants