Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit current "DepthMap" implementation #184

Open
NiklasRentzCAU opened this issue Jul 23, 2024 · 0 comments
Open

Revisit current "DepthMap" implementation #184

NiklasRentzCAU opened this issue Jul 23, 2024 · 0 comments
Labels
enhancement New feature or request klighd-core

Comments

@NiklasRentzCAU
Copy link
Member

Currently we use the DepthMap to pre-calculate detail levels (out of bounds, minimal details, full details) for "regions" before rendering, and using that information in subsequent svg rendering calls.
I think we do not need to pre-calculate this at all and can therefore remove the DepthMap entirely, in exchange for simply doing an out-of-bounds and relative size check during the rendering (computationally inexpensive, done so per default in Sprotty's examples). Furthremore, some pre-rendering-checks such as calculating the absolute scale of elements can then be either done in some other, fast pre-rendering step or also on the fly during rendering itself, stored in properties of the graph for persistence.

This would remove this clutter inconsistent with Sprotty and will also solve other issues related to the DepthMap #77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request klighd-core
Projects
None yet
Development

No branches or pull requests

1 participant