Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent baseDiv in CLI and VS Code extension #179

Open
NiklasRentzCAU opened this issue Jun 10, 2024 · 0 comments
Open

Inconsistent baseDiv in CLI and VS Code extension #179

NiklasRentzCAU opened this issue Jun 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@NiklasRentzCAU
Copy link
Member

Currently the VS Code extension uses the baseDiv for Sprotty of "keith-diagram_sprotty", whereas the CLI uses just "sprotty", potentially causing inconsistencies between both executables, see e.g. #178. Furthermore, the "keith-diagram" string is still a somewhat magic string around the code base. Both implementations should use the same base ID and no magic strings for this, but rather read it from the options, as was done to fix the issue in #178 as well.

@NiklasRentzCAU NiklasRentzCAU added the enhancement New feature or request label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant