Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter's order #165

Open
meiyasan opened this issue Oct 24, 2022 · 2 comments
Open

Filter's order #165

meiyasan opened this issue Oct 24, 2022 · 2 comments

Comments

@meiyasan
Copy link

Hello @dlevin256 ,

Is there any plan in KFR5.0 to compute the filter's order based on gPass/gStop parameters like in SciPy ?
https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.ellipord.html (instead of providing an integer N)

This is something I am using everyday that is very useful.
At this time I have to guess the order (or compute it myself based on dB variations I want).
@meiyasan meiyasan changed the title Filter ordering Filter's order Oct 24, 2022
@meiyasan
Copy link
Author

I just pushed a commit I implemented last week and got tested this week.
meiyasan@16b2702

This is not kfr style again, sorry about that. I hope this might enhance the use of this library.

@dancazarin
Copy link
Member

Hello Marco,

Computing the filter order is definitely a good feature for KFR 5.x.
Thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dancazarin @meiyasan