Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(common): look at precompiling ajv schemas in common/types #9640

Closed
Tracked by #9621
mcdurdin opened this issue Sep 28, 2023 · 0 comments · Fixed by #9691
Closed
Tracked by #9621

chore(common): look at precompiling ajv schemas in common/types #9640

mcdurdin opened this issue Sep 28, 2023 · 0 comments · Fixed by #9691
Labels
chore common/
Milestone
A17S23

Comments

@mcdurdin
Copy link
Member

@mcdurdin mcdurdin added this to the A17S23 milestone Sep 28, 2023
This was referenced Sep 28, 2023
Merged
Merged
mcdurdin added a commit that referenced this issue Oct 5, 2023
@mcdurdin
feat(common): precompile json schemas to improve performance
225877f 
Fixes #9640.

This ended up being somewhat more fragile than originally anticipated.
For the `ajv` cli call to get the right versions, we needed to install
ajv as a dev dependency in the top-level package.json as well as at the
common/web/types level.

Ajv does not do all that well with ESM yet, either, so we use esbuild to
transform the compiled validators before building in typescript.
@mcdurdin mcdurdin linked a pull request Oct 6, 2023 that will close this issue
feat(common): precompile ajv schemas 🎺 #9691
Merged
@mcdurdin mcdurdin closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore common/
Projects
None yet
Milestone
A17S23
Development

Successfully merging a pull request may close this issue.

feat(common): precompile ajv schemas 🎺 keymanapp/keyman
1 participant
@mcdurdin