Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry #56

Open
k1ng440 opened this issue Jun 15, 2018 · 4 comments
Open

OpenTelemetry #56

k1ng440 opened this issue Jun 15, 2018 · 4 comments

Comments

@k1ng440
Copy link

k1ng440 commented Jun 15, 2018

Opentracing integration would be great

http://opentracing.io/

@AlexCuse
Copy link
Contributor

AlexCuse commented Jul 8, 2023

Happy to open a PR for this, assume we should use opentelemetry at this point https://github.com/open-telemetry/opentelemetry-go/tree/main/trace

@k1ng440
Copy link
Author

k1ng440 commented Jul 8, 2023

I agree. OpenTelemetry is the new standard.

@AlexCuse
Copy link
Contributor

AlexCuse commented Jul 8, 2023

Hardest part is that there isn't much context usage in the internal apis currently so span propagation is tough. It's easy enough to add but makes for a large change.

Guessing db / redis actions and bcrypt operations are probably most interesting to get spans around did you have anything else in mind?

@k1ng440 k1ng440 changed the title Opentracing OpenTelemetry Jul 10, 2023
@k1ng440
Copy link
Author

k1ng440 commented Jul 10, 2023

Hardest part is that there isn't much context usage in the internal apis currently so span propagation is tough.

I remember trying to implement opentracing back in 2018 but I gave up because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants