Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log node/ec2 instance name on nodes.drainNode error #115

Open
karimlakhani opened this issue May 24, 2023 · 0 comments
Open

Log node/ec2 instance name on nodes.drainNode error #115

karimlakhani opened this issue May 24, 2023 · 0 comments

Comments

@karimlakhani
Copy link

karimlakhani commented May 24, 2023

Is this a BUG REPORT or FEATURE REQUEST?:
feature request
What happened:
error logging does not include the node name / ec2 instance id
What you expected to happen:
when logging the error, include the node name / ec2 instance id
How to reproduce it (as minimally and precisely as possible):
you need the drainNode to fail for some reason other than if err.Error() == "command execution timed out" {
Anything else we need to know?:

Environment:
ALl

  • Kubernetes version:
    All
kubectl version -o yaml

Other debugging information (if applicable):
this is the code https://github.com/keikoproj/lifecycle-manager/blob/7084174977de0a30f20fa2ba8e545383f4067575/pkg/service/nodes.go#LL67C1-L68C1

  • relevant logs:
kubectl logs <lifecycle-manager-pod>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant