Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot modify HTTPScaledObjects after moving from 0.7.0 to 0.8.0 #1020

Open
jocelynthode opened this issue May 7, 2024 · 10 comments
Open

Cannot modify HTTPScaledObjects after moving from 0.7.0 to 0.8.0 #1020

jocelynthode opened this issue May 7, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@jocelynthode
Copy link
Contributor

jocelynthode commented May 7, 2024

Report

After upgrading to 0.8.0. The CRD seems to have changed and the enum for status.conditions[].type now only supports Ready as a value.

Before this update to the CRD we supported the following values:

- Created
- Error
- Pending
- Unknown
- Terminating
- Terminated
- Ready

I was able to workaround it by editing the CRD and readding these statuses and then edit them so that the status conditions could be cleaned up.

Expected Behavior

I expect to be able to edit old HTTPScaledObjects

Actual Behavior

Old HTTPScaledObjects fail to be edited with the following messages:

* status.conditions[414].type: Unsupported value: "Pending": supported values: "Ready"
* status.conditions[415].type: Unsupported value: "Created": supported values: "Ready"
* status.conditions[417].type: Unsupported value: "Pending": supported values: "Ready"
* status.conditions[418].type: Unsupported value: "Created": supported values: "Ready"
* status.conditions[420].type: Unsupported value: "Pending": supported values: "Ready"
* status.conditions[421].type: Unsupported value: "Created": supported values: "Ready"
* status.conditions[423].type: Unsupported value: "Pending": supported values: "Ready"
* status.conditions[424].type: Unsupported value: "Error": supported values: "Ready"

Steps to Reproduce the Problem

  1. Have an old HTTPScaledObject with some status conditions other than Ready
  2. Update to 0.8.0
  3. Try to edit the HTTPScaledObjects

Logs from KEDA HTTP operator

No response

HTTP Add-on Version

0.8.0

Kubernetes Version

1.27

Platform

Other

Anything else?

No response

@jocelynthode jocelynthode added the bug Something isn't working label May 7, 2024
@massimeddu-sj
Copy link

massimeddu-sj commented May 7, 2024

Same issue here on Kubernetes 1.29.

Thanks @jocelynthode , your work around worked just fine.

@JorTurFer
Copy link
Member

f**k I didn't notice that changing the status fields I can break the CRD :/
The HTTP Add-on shouldn't use them anymore either but probably it doesn't remove them if they are already there. Does it fail after the rollout of the new version is completed?

@JorTurFer
Copy link
Member

I'm asking because we have to include a check for removing those states from the HTTPScaledObject if they are available

@jocelynthode
Copy link
Contributor Author

f**k I didn't notice that changing the status fields I can break the CRD :/ The HTTP Add-on shouldn't use them anymore either but probably it doesn't remove them if they are already there. Does it fail after the rollout of the new version is completed?

Yes The upgrade to 0.8.0 was successful and everything seemed to be working. Then when I wanted to edit HTTPScaledObjects created before the upgrade I was met with the error. The problem is indeed that it does not remove old statuses and thus after the upgrades prevents objects with old statuses to be updated.

@JorTurFer
Copy link
Member

Yes The upgrade to 0.8.0 was successful and everything seemed to be working. Then when I wanted to edit HTTPScaledObjects created before the upgrade I was met with the error. The problem is indeed that it does not remove old statuses and thus after the upgrades prevents objects with old statuses to be updated.

Thanks for the feedback, I'm going to try to fix this during the week and cut a fix release. I thought that old values were dropped automatically but apparently not (every day you learn things xD). The operator will drop them during the upgrade for future releases. Sorry for the inconvenience

@jocelynthode
Copy link
Contributor Author

No worries, thanks for the work 🙂

@oto-macenauer-absa
Copy link

just encountered this, bumping so it doesn't get stale:)

@jocelynthode
Copy link
Contributor Author

@JorTurFer : Any update on this issue? It's been a few months with no releases.

Copy link

stale bot commented Sep 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Sep 17, 2024
@jocelynthode
Copy link
Contributor Author

Do not close

@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To Triage
Development

No branches or pull requests

4 participants