Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kamon can not work with datadog agent #137

Open
uname-yang opened this issue Dec 15, 2021 · 17 comments
Open

kamon can not work with datadog agent #137

uname-yang opened this issue Dec 15, 2021 · 17 comments

Comments

@uname-yang
Copy link

Hi
we use kamon and datadog together. but it conflict with datadog agent from version 0.55.
is there any way to solve this ?

image

thanks

@dpsoft
Copy link
Contributor

dpsoft commented Dec 15, 2021

Hi @uname-yang, are you using the kamon bundle? can you try adding the kanela agent jar to the jvm params like -J-javaagent:dd-java-agent.jar -J-javaagent:kanela-agent.jar?

@uname-yang
Copy link
Author

image

still not work by using jvm opts

@dpsoft
Copy link
Contributor

dpsoft commented Dec 20, 2021

@uname-yang only for double check:

  • if you run only with kanela, works?
  • if you change the order of execution of the agent like: kanela then dd or dd then kanela, works?

Also you can add kanela.debug-mode = true in your application.config in order to get more information over the instrumentation process.

@ivantopo any thoughts?

@uname-yang
Copy link
Author

uname-yang commented Dec 21, 2021

@dpsoft thanks for checking:

  1. we can run only with kanela. It works.
  2. it's no different when exchange the order.

attach the log here

log.txt

I guess there must be some common lib using by dd and kamon , such as bytebuddy, only can be applied once.

@dpsoft
Copy link
Contributor

dpsoft commented Dec 22, 2021

@uname-yang can you try disabling okhttp instrumentation -> kanela.modules.okhttp-module.enabled=false? I think kanela is trying to instrument the okhttp client inside of dd-agent. An in a second try you can comment //Kamon.init() and pass the agent as JVM argument.

Thanks in advance.

@uname-yang
Copy link
Author

uname-yang commented Dec 23, 2021

@dpsoft i check the source code. It seems okhhttp-module does not have enabled flag.
Here is the error log when start app as your suggestion, same as before:
image

@dpsoft
Copy link
Contributor

dpsoft commented Dec 23, 2021

@uname-yang all kanela modules inherit the module configuration with some default values described in kanela [configuration]. Can you try adding

kanela {
   debug-mode = true
   log-level = "DEBUG"
   modules.okhttp-module.enabled = false
}
 
and share the log with us?


[configuration]: https://github.com/kamon-io/kanela/blob/master/agent/src/main/resources/reference.conf#L23

@uname-yang
Copy link
Author

log.txt

Please help and advise. Thanks

@uname-yang
Copy link
Author

@uname-yang all kanela modules inherit the module configuration with some default values described in kanela [configuration]. Can you try adding

kanela {
   debug-mode = true
   log-level = "DEBUG"
   modules.okhttp-module.enabled = false
}
 
and share the log with us?


[configuration]: https://github.com/kamon-io/kanela/blob/master/agent/src/main/resources/reference.conf#L23

any updates?

@stewart-shawn
Copy link

Is there any update on this? We have the same issue.

@dpsoft
Copy link
Contributor

dpsoft commented May 18, 2022

Hi @uname-yang @stewart-shawn, any chance to make a minimal executable example to play with and try to reproduce the problem?

@stewart-shawn
Copy link

@dpsoft No problem. I've added an example here: https://github.com/stewart-shawn/dd-kamon-demo. Thanks for checking into this

@dpsoft
Copy link
Contributor

dpsoft commented May 18, 2022

@stewart-shawn awesome, I will take a look ASAP

@nmadhavi33
Copy link

@dpsoft any update on this issue? we have the same issue

@anujprashar
Copy link

anujprashar commented Jun 30, 2022

@dpsoft @ivantopo Is this fixed or when can we expect this to be fixed. we are blocked due to this.

@uname-yang
Copy link
Author

@stewart-shawn awesome, I will take a look ASAP

any updates here?

@siddshuk
Copy link

siddshuk commented Oct 7, 2022

@dpsoft - Currently blocked due to this as well. Did you get a chance to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants