Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic values in paths are not replaced with placeholders #51

Open
lolgab opened this issue Feb 9, 2023 · 1 comment
Open

Dynamic values in paths are not replaced with placeholders #51

lolgab opened this issue Feb 9, 2023 · 1 comment

Comments

@lolgab
Copy link

lolgab commented Feb 9, 2023

Hi and thank you for this library!
I'm in the progress of migrating an application from akka-http to http4s and I noticed a behavioral difference.
While in akka-http paths are reported to Prometheus with a {} placeholder when the segment contains dynamic values (like integers), in http4s paths are reported literally:
For example:

with http4s:

/v1/organization/30755/authors/suggested

with akka-http:

/v1/organization/{}/authors/suggested

Is this intended? Can I configure Kamon to have the same behavior? In case it's a missing feature, are you willing to merge a PR implementing the change (maybe guiding me to show what needs to be changed)

Thank you!
Lorenzo

@lolgab
Copy link
Author

lolgab commented Feb 10, 2023

I searched {} in the Kamon codebase and it seems to me that here is where the paths are modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant