Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop kardianos/service dependency #4962

Open
jnummelin opened this issue Sep 12, 2024 · 3 comments · May be fixed by #5009
Open

Drop kardianos/service dependency #4962

jnummelin opened this issue Sep 12, 2024 · 3 comments · May be fixed by #5009
Labels
area/cli chore

Comments

@jnummelin
Copy link
Member

jnummelin commented Sep 12, 2024 •
edited
Loading

We anyways already provide our own templates for system units and thus do not depend that much on the library functionality.

kardianos/service is not really maintained, there's e.g. a bug fix PR opened by myself on June 2023 which has not been merged.

I propose that we drop the whole dependency, use our own templates fully and provide needed wrappers around. We handle much of the same/similar logic in k0sctl/rig side already and thus known what needs to be done.
@kke
Copy link
Contributor

kke commented Sep 12, 2024 •
edited
Loading

@kke kke linked a pull request Sep 18, 2024 that will close this issue
Draft
16 tasks
@kke kke mentioned this issue Sep 26, 2024
Merged
16 tasks
This was referenced Sep 30, 2024
Merged
Merged
Merged
@github-actions GitHub Actions
Copy link
Contributor

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Oct 12, 2024
@twz123 twz123 removed the Stale label Oct 13, 2024
@makhov
Copy link
Contributor

makhov commented Oct 22, 2024

We had a bug in the current implementation (here is the fix), so let's also add some unit tests to make sure, that the generated services are correct

@apedriza apedriza mentioned this issue Oct 22, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cli chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(wip) Drop kardianos service k0sproject/k0s
4 participants
@kke @makhov @twz123 @jnummelin