-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOVE this! #1
Comments
One note, I cannot get the text input to filter the available commands. It looks like focus cannot be set on the input text field. |
Apologies, I just realized that the intent of the .searchBox was to capture input, not filter the commands (feature request!). As such, I made a small change for your review that hides the text box while still capturing input (look for SCOCHANGE and SCOADD in showPalette() and addStyles()):
|
Thanks for the feedback @sottey ! I'd be interested in if you get the slash command thing working as well, I had thought about doing something like that first but it seemed more complicated even though ckeditor seems to have some built-in support for it.
|
Good catch! I didn't think about the theming. It looks like you're using a light theme, I had picked the colors based on the dark theme I was using. I'm looking into re-using some of the code for the Jump-to menu. If I can get that to work, I think it'll be better since it'd use the colors from the theme you have selected |
Just to double check, @sottey does the latest version fix the issues you had with the text colors? It should be using the theme colors now |
It totally does! Also, regarding the #widget vs. #run=frontEndStartup: it looks like unexpected things happen when you use widget for things that it isn't intended for. I am still a little unclear on it, but there is a discussion here that is a start. |
A If you don't need the functionality of that widget class or don't want the UI support it has, use |
I have been working on a Slack-like forward slash functionality that does something similar. Your idea is MUCH more intuitive.
One note that I didn't see in the instructions:
When you first enter Trilium, you must execute the code (click on the running man icon in the note) for it to respond to the key combo or swipe down. To address this, one can just add the attribute "#widget" to the palette command code note.
I have structured it like this:
A container note, then a code note holding the widget and a Command note which contains all my callable notes.
Again, I LOVE this, thank you!
Sean
The text was updated successfully, but these errors were encountered: