Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query string does not work #56

Open
donny-dont opened this issue Nov 12, 2013 · 4 comments
Open

Query string does not work #56

donny-dont opened this issue Nov 12, 2013 · 4 comments

Comments

@donny-dont
Copy link

Currently the '?' character is not marked as a special character so when encountered it does not add a \ in front of it. Adding ? within the string itself does not help as this gets stripped.

@pavelgj
Copy link
Contributor

pavelgj commented Nov 12, 2013

Are you using route or route_hierarchical?

@justinfagnani
Copy link
Owner

It's just route, I'm looking into it now, the example hasn't been updated
for 1.0, so it's likely that the server isn't running at all.

On Mon, Nov 11, 2013 at 7:14 PM, Pavel Jbanov [email protected]:

Are you using route or route_hierarchical?


Reply to this email directly or view it on GitHubhttps://github.com//issues/56#issuecomment-28264654
.

@justinfagnani
Copy link
Owner

Oops, I got my signals crossed between here and Stack Overflow :) disregard

On Mon, Nov 11, 2013 at 7:18 PM, Justin Fagnani [email protected]:

It's just route, I'm looking into it now, the example hasn't been updated
for 1.0, so it's likely that the server isn't running at all.

On Mon, Nov 11, 2013 at 7:14 PM, Pavel Jbanov [email protected]:

Are you using route or route_hierarchical?


Reply to this email directly or view it on GitHubhttps://github.com//issues/56#issuecomment-28264654
.

@donny-dont
Copy link
Author

Not sure if I need to be more specific but just in case. If you have a url you're trying to match that looks like

http://foo.com/index.html?bar=123

If you tried to make a UrlPattern to get the value of bar you can't because the ? is not treated as a special character that should have a \ added to it. This is because of the following from url_pattern.dart

final _specialChars = new RegExp(r'[\^\$\.\|\+\[\]\{\}]');

Which does not contain ?. You also can't just add a ? to the pattern as the \ gets removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants