feat(euclid): add dynamic routing in core flows #6333
+460
−364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 11 of 11 files. Overall, the semantic diff is 26% smaller than the GitHub diff.
|
prajjwalkumar17
added
A-routing
hyperswitch-bot
bot
added
the
M-api-contract-changes
Chethan-rao
requested changes
Oct 17, 2024
Comment on lines
+547
to
+552
| self.success_based_algorithm = Some(SuccessBasedAlgorithm { | ||
| algorithm_id_with_timestamp: DynamicAlgorithmWithTimestamp { | ||
| algorithm_id: Some(new_id), | ||
| timestamp: common_utils::date_time::now_unix_timestamp(), | ||
| }, | ||
| enabled_feature, |
There was a problem hiding this comment.
Nit:
Can use constructor
Chethan-rao
requested changes
Oct 18, 2024
crates/router/src/core/routing.rs
Outdated
Comment on lines
1321
to
1330
| let _ = cache::publish_into_redact_channel( | ||
| state.store.get_cache_store().as_ref(), | ||
| cache_entries_to_redact, | ||
| ) | ||
| .await | ||
| .to_not_found_response(errors::ApiErrorResponse::ResourceIdNotFound)?; | ||
| let response = record.foreign_into(); | ||
| helpers::update_business_profile_active_dynamic_algorithm_ref( | ||
| db, | ||
| key_manager_state, | ||
| &key_store, | ||
| business_profile, | ||
| dynamic_routing_algorithm, | ||
| ) | ||
| .await?; | ||
|
|
||
| metrics::ROUTING_UNLINK_CONFIG_SUCCESS_RESPONSE.add( | ||
| &metrics::CONTEXT, | ||
| 1, | ||
| &add_attributes([("profile_id", profile_id.get_string_repr().to_owned())]), | ||
| ); | ||
|
|
||
| Ok(service_api::ApplicationResponse::Json(response)) | ||
| } else { | ||
| Err(errors::ApiErrorResponse::PreconditionFailed { | ||
| message: "Algorithm is already inactive".to_string(), | ||
| })? | ||
| .map_err(|e| { | ||
| logger::error!( | ||
| "unable to publish into the redact channel for evicting the success based routing config cache {e:?}" | ||
| ) | ||
| }); |
There was a problem hiding this comment.
Shouldn't we propagate the error if publishing to cache fails? because core will still get the configs from cache and may perform SR?
There was a problem hiding this comment.
Yes, propagation seems fine here.
|
Please add debug logs wherever necessary |
NishantJoshi00
previously approved these changes
Oct 21, 2024
Chethan-rao
requested changes
Oct 21, 2024
crates/router/src/core/payments.rs
Outdated
| @@ -4579,40 +4579,35 @@ where | |||
| .await | |||
| .change_context(errors::ApiErrorResponse::InternalServerError)?; | |||
|
|
|||
| let connectors = routing::perform_eligibility_analysis_with_fallback( | |||
There was a problem hiding this comment.
I see this is adding the fallback as well to the list and this list is getting sent to perform SR. We should only perform eligibility analysis on the connectors and send only these filtered connectors to perform SR instead of adding the fallback too. Fallback connectors should be appended to the list obtained after performing SR
There was a problem hiding this comment.
This will be addressed in this PR.
Chethan-rao
approved these changes
Oct 21, 2024
| use crate::{core::metrics as core_metrics, routes::metrics}; | ||
| #[cfg(feature = "v1")] | ||
| use crate::{core::metrics as core_metrics, routes::metrics, types::transformers::ForeignInto}; | ||
| pub const DYNAMIC_ALGORITHM_NAME: &str = "Dynamic routing algorithm"; |
There was a problem hiding this comment.
Isn't this a success routing algorithm?
NishantJoshi00
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This will add dynamic_routing in core flows.
After which once the toggle route is hit with
feature = dynamic_connector_selection, routable connectors will be evaluated on basis of success_based routing.Additional Changes
Motivation and Context
Will enable success_based routing
How did you test it?
The testing flows are as follows:
dynamic_connector_selection.Checklist
cargo +nightly fmt --allcargo clippy