Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace deprecated backticks with $(...) for command substitution #6337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace deprecated backticks with $(...) for command substitution #6337

wants to merge 1 commit into from
+39 −41

Conversation

Sidharth-Singh10
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Use $(...) notation instead of legacy ... in the shell files.
Removes the use of deprecated backticks notation (cf. SC2006).

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Fixes #6271

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sidharth-Singh10 Sidharth-Singh10 requested a review from a team as a code owner October 16, 2024 08:15
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@Sidharth-Singh10 Sidharth-Singh10 changed the title fix:replace deprecated backticks with for command substitution fix: replace deprecated backticks with for command substitution Oct 16, 2024
@gorakhnathy7 gorakhnathy7 added the hacktoberfest Issues that are up for grabs for Hacktoberfest participants label Oct 16, 2024
@Sidharth-Singh10 Sidharth-Singh10 changed the title fix: replace deprecated backticks with for command substitution fix: replace deprecated backticks with $(...) for command substitution Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

At least 2 approving reviews are required to merge this pull request.

Assignees

@Sidharth-Singh10 Sidharth-Singh10

Labels
hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Do not use backticks in shell files
2 participants
@Sidharth-Singh10 @gorakhnathy7