-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mime type of Javascript inferred incorrectly for Tensorboard #405
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
jupyter-server-proxy should be proxying everything though. What mimetype header is sent by tensorboard? |
Seems like that is text/html, however when run directly it is javascript. I
will run locally without proxy and report.
…On Fri, 28 Apr 2023, 18:38 Simon Li, ***@***.***> wrote:
jupyter-server-proxy should be proxying everything though. What mimetype
header is sent by tensorboard?
—
Reply to this email directly, view it on GitHub
<#405 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADX7BEZE2BUZLD3OZ7L663XDOCKBANCNFSM6AAAAAAXO3U5ME>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
We use tensorboard with JSP and JupyterLab and we didnt see any issues. Which version of tensorboard are you using? |
Bug description
Mime type inference failure for tensorboard javascript file served by application with a query parameter.
Expected behaviour
Tensorboard application running withing Notebook container should load without issues in browsers with the MIME Type verification security feature enabled i.e. resources are not loaded if the browser sniffed MIME type is different from the server advertised mime type.
https://blog.mozilla.org/security/2016/08/26/mitigating-mime-confusion-attacks-in-firefox/
Actual behaviour
JupyterHub proxy fails to infer mimetype of file such as index.js?_file_hash=8b6358c7 as text/javascript
How to reproduce
Your personal set up
Zero-to-JupyterHub on EKS
JupyterHub on EKS with Image built from Ubuntu 22.04
JupyterHub : 3.11
Python : 3.10.6
The text was updated successfully, but these errors were encountered: