Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building yarn package on install #105

Open
cabreraalex opened this issue Sep 21, 2021 · 3 comments
Open

Building yarn package on install #105

cabreraalex opened this issue Sep 21, 2021 · 3 comments

Comments

@cabreraalex
Copy link
Contributor

I was curious if people know why the setup.py builds the package on install:

install_npm(HERE, build_cmd='build:prod'),

It looks like nbextension and labextension are both pre-built and bundled, so it isn't necessary to run npm and build:prod on install. This has also been breaking for people who do not have yarn or npm installed.

@cabreraalex
Copy link
Contributor Author

On a related note, it looks like jupyter_packaging does not support the sdist packaging in the docs:
https://github.com/jupyter/jupyter-packaging/blob/master/README.md#usage-notes

@blink1073
Copy link
Contributor

A short term fix is to us skip_if_exists to skip the npm build if one of the built files exists. A better solution is to adopt the jupyter_packaging backend in this cookiecutter.

@cabreraalex
Copy link
Contributor Author

Fix at #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants