Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH]: Validate boolean parameters passed from yaml file #296

Open
tomug opened this issue Jan 26, 2024 · 0 comments
Open

[ENH]: Validate boolean parameters passed from yaml file #296

tomug opened this issue Jan 26, 2024 · 0 comments
Assignees
@synchon
Labels
enhancement New feature or request

Comments

@tomug
Copy link
Contributor

tomug commented Jan 26, 2024

I erroneously passed a list to the DataladHCP1200 data grabber trying to set the ica_fix parameter to false but provided it in list notation. The data grabber ended up getting the FIX-cleaned data, because the list was resolved to true.

Suggested solve: validate the parameters so if a boolean is expected and a list is given one gets an error.
@tomug tomug added the enhancement New feature or request label Jan 26, 2024
@tomug tomug added the triage New issues waiting to be reviewed label Jan 26, 2024
@synchon synchon removed the triage New issues waiting to be reviewed label Feb 26, 2024
@fraimondo fraimondo mentioned this issue Sep 24, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@synchon synchon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fraimondo @synchon @tomug