Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTPS sources #3

Open
jsdw opened this issue Jun 6, 2019 · 6 comments
Open

Support HTTPS sources #3

jsdw opened this issue Jun 6, 2019 · 6 comments
Labels
Idea An idea for a new feature/update

Comments

@jsdw
Copy link
Owner

jsdw commented Jun 6, 2019

Weave currently can proxy requests to https endpoints, but only supports serving up content on http at the moment.

Serving content on https would require either a pre existing or self signed certificate to be used.

While less useful perhaps during development, https is handy if you are demoing things you're hacking on and such, especially if any sort of sensitive data is sent either way. It would also be handy if weave added any sort of authentication (eg basic auth) support to restrict access to things being served up (use case: quick file server with basic access control)

@jsdw jsdw added the Idea An idea for a new feature/update label Jun 6, 2019
@davidgraeff
Copy link

Hyper supports http2. Would support for Https connections (certificate management in weave) also mean http2 support? If so weave could be used for gRPC proxying, I guess.

@jsdw
Copy link
Owner Author

jsdw commented Nov 23, 2019

Interesting question; hyper is used to receive and send on http traffic and so I'd assume it at least supports http2, but it would need to be tested! If you do get the chance to try this, let me know what you find :)

@jsdw
Copy link
Owner Author

jsdw commented Nov 24, 2019

(I just wanted to note that weave can be used as a tcp proxy as well, which would transparently proxy any tcp traffic without caring about the contents, so this would allow basic http2 proxying, just without any routing bits)

@davidgraeff
Copy link

Absolutely. But the routing bits are the interesting parts. I'm still waiting for hyper to release a new version that uses stable futures-rs before I investigate any other code base.

@vi
Copy link

vi commented Sep 15, 2020

Is this going to be implemented?

What is maintainership status of weave in general?

@jsdw
Copy link
Owner Author

jsdw commented Sep 15, 2020

I don't have a use case for this support nowadays, but I'd happily accept a PR which adds it :)

I'm not actively adding features to weave at the moment (what it has is suitable for the sorts of things I use it for), but every now and then I may tweak and refine bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea An idea for a new feature/update
Projects
None yet
Development

No branches or pull requests

3 participants