-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slack auth support #2
Comments
https://api.slack.com/methods/users.info We would be able to differentiate Slack admins with this endpoint, so we can reject the command if they aren't an admin. Will need a new scope, which I didn't predict. Apologies. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I think its time to review this task again since auth is finally live. @MartinKolarik Any thoughts or clarifications? @radulucut please check as well |
Overview
Implementation details
|
@MartinKolarik I'm not sure where |
I was thinking here which is then publicly reachable at |
Then, the redirect URL should be |
In production yes, but the client I gave you has the localhost URL configured so that you can use it in dev. That's why the |
Once we have the API functionality we need to support it in the app too. I was thinking something like this:
The admin part is to discourage random users in the Slack org from using it.
It should open a new browser tab and close it if possible when user is done.
Can we somehow differentiate between user permissions? To limit that command only to admins. If not then I guess we just have to hope no user will abuse it.
Additional new related commands:
The text was updated successfully, but these errors were encountered: