Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the modern unified CMake FindPython module #708

Open
ManifoldFR opened this issue Aug 8, 2024 · 2 comments
Open

Use the modern unified CMake FindPython module #708

ManifoldFR opened this issue Aug 8, 2024 · 2 comments

Comments

@ManifoldFR
Copy link
Contributor

This would be this module, which looks for Python version 3 by default, otherwise version 2.

It provides targets which are namespaced as Python:: (e.g. Python::Module for the Development.Module component), which is the expected format for some modern libraries such as nanobind (if the targets are not found, it even does a find_package(Python ...) call, which is the FindPython module), as I discussed with @nim65s

I think a copy of that module is already available in this directory?

@ManifoldFR ManifoldFR changed the title Use the modern CMake FindPython module Use the modern unified CMake FindPython module Aug 8, 2024
@nim65s
Copy link
Collaborator

nim65s commented Aug 8, 2024

FindPython was added CMake 3.12, and unfortunately we are still keeping compatibility with 3.10.

CMake 3.10 is the version provided by 18.04. I think we should be able to drop 18.04 support to bump to CMake 3.16, and get this FindPython module without the need for using a local copy soon.

@ManifoldFR
Copy link
Contributor Author

Until we drop 18.04, we could still use our local copy, though, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants