Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move INSTALL_GENERATED_HEADERS option to PROJECT_ variable? #557

Open
gergondet opened this issue Sep 14, 2022 · 3 comments
Open

Move INSTALL_GENERATED_HEADERS option to PROJECT_ variable? #557

gergondet opened this issue Sep 14, 2022 · 3 comments

Comments

@gergondet
Copy link
Member

As I was working on #556 I noticed we provide INSTALL_GENERATED_HEADERS as an option and I think it doesn't make too much sense. On the one hand, if the headers are required for the project to work properly then disabling the option would prevent the proper use of the project. On the other hand, if the headers are not required by the project it should be up to the maintainers to decide whether or not to ship them along the project (for example config.hh can be useful outside the project even if not used internally)

What would you think of moving this option to a PROJECT_INSTALL_GENERATED_HEADERS variable instead that can be set by maintainers?

@jcarpent
Copy link
Contributor

Fine on my side. Could you mention that the var is deprecated to smooth the transition?

@nim65s
Copy link
Collaborator

nim65s commented Sep 14, 2022

Is there any difference between INSTALL_GENERATED_HEADERS and PROJECT_INSTALL_GENERATED_HEADERS, other that the name of the variable ?

@gergondet
Copy link
Member Author

Fine on my side. Could you mention that the var is deprecated to smooth the transition?

Sure. @wxmerkt do CMake's AUTHOR_WARNING generates warning in the ROS build farm?

Is there any difference between INSTALL_GENERATED_HEADERS and PROJECT_INSTALL_GENERATED_HEADERS, other that the name of the variable ?

INSTALL_GENERATED_HEADERS is an option but PROJECT_INSTALL_GENERATED_HEADERS would not be. We could simply move INSTALL_GENERATED_HEADERS to a variable instead of an option but I like the idea of uniformizing those PROJECT_ settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants