Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of locals() vague #7

Open
jpavlav opened this issue Mar 23, 2019 · 0 comments
Open

Use of locals() vague #7

jpavlav opened this issue Mar 23, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jpavlav
Copy link
Owner

jpavlav commented Mar 23, 2019

Considering changing how payloads are handled. Utilizing locals() allowed for some pretty code and less lines overall, but considering the number of possible arguments to many of the calls related to creation or editing of resources such as monitors, psp's, etc, it might be better to create separate classes representing each type of payload.

The classes could have as their attributes the possible arguments to the API call itself. This would demystify things a bit. More code, less concise. More readable, probably less prone to error. Likely going to start working on a refactor to support these ideas.

@jpavlav jpavlav added the enhancement New feature or request label Mar 23, 2019
@jpavlav jpavlav self-assigned this Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant