Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kit CLI allows for multi-level Repository names to be "packed" in the Local Registry #393

Closed
brett-hodges opened this issue Jul 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@brett-hodges
Copy link
Contributor

Describe the bug
kit pack accepts Repository names with multiple-levels beyond what is expected.

To Reproduce
Steps to reproduce the behavior:

  1. Download the attached file: kitfile-directory-test.tar.gz to a directory of your choosing.
  2. From a terminal window, extract the file with the command tar -xvzf kitfile-directory-test.tar.gz
    3.cd kit file-directory-test
  3. kit pack . -t jozu.ml/repo-path/repo-subpath/mykitfile:latest
  4. Run kit list to confirm the addition of the ModelKit to the local registry even though it had too many levels in its Repository name.

Version
latest

Additional context

@brett-hodges brett-hodges added the bug Something isn't working label Jul 4, 2024
@amisevsk
Copy link
Contributor

amisevsk commented Jul 4, 2024

This is technically allowed by some repositories: https://github.com/users/amisevsk/packages/container/package/testone%2Ftesttwo%2Ftestthree

@brett-hodges
Copy link
Contributor Author

brett-hodges commented Jul 5, 2024

Correct. I can successfully kit push a ModelKit containing a multi-level repository path to ghcr.io; but, I can't successfully kit push a ModelKit containing a multi-level repository path to jozu.ml. Instead, I get an ambiguous error message:

Pushing jozu.ml/jozu-test/repo-level-testing/mymodel:latest
Failed to push: failed to copy to remote: Not Found (additional info: {"status":404,"error":"Not Found"})

I'm closing this request in favor of:

  1. Opening an Enhancement Request agains KitOps kit push to provide more clear error messaging when a repo fails to be pushed because its name contains multiple levels. #394
  2. Opening an Enhancement Request for Jozu.ml to accept multi-level Repository names #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants