Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong pattern for Greek SSNs #2121

Open
nepiskopos opened this issue Oct 15, 2024 · 3 comments · May be fixed by #2120
Open

Wrong pattern for Greek SSNs #2121

nepiskopos opened this issue Oct 15, 2024 · 3 comments · May be fixed by #2120

Comments

@nepiskopos
Copy link

ssn = self.generator.date(pattern="%d%m%y") + self.numerify("####")

  • Faker version: v30.3.0
  • OS: Linux

Expected behavior

Proper format / pattern should be "%d%m%y#####".

Actual behavior

Current format / pattern is "%d%m%y####".

@nepiskopos nepiskopos linked a pull request Oct 15, 2024 that will close this issue
@nepiskopos
Copy link
Author

It looks like that, and these documents can prove this:

https://learn.microsoft.com/en-us/purview/sit-defn-greece-social-security-number#pattern

https://docs.trellix.com/bundle/data-loss-prevention-11.10.x-classification-definitions-reference-guide/page/GUID-113631C2-C1E5-41FF-8794-B22A90EE2E61.html

Exactly, one of the cited sources states that a Greek SSN consists of

  • Six digits as date of birth YYMMDD
  • Four digits
  • a check digit

So, proper format / pattern in faker should be "%d%m%y#####", having 5 digits after date of birth instead of 4 (which is the current behavior).

@stefan6419846
Copy link
Contributor

You probably want to update/fix the existing links inside the current code in this case as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants