Skip to content
This repository has been archived by the owner on Jan 24, 2020. It is now read-only.

Does react-native-cookies 3.3.0, support RN 0.59.4? #138

Open
PurnimaNaik opened this issue Apr 12, 2019 · 5 comments
Open

Does react-native-cookies 3.3.0, support RN 0.59.4? #138

PurnimaNaik opened this issue Apr 12, 2019 · 5 comments

Comments

@PurnimaNaik
Copy link

No description provided.

@Noitidart
Copy link

I don't think so, I'm getting a lot of errors on compile

> Configure project :react-native-cookies
WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html
WARNING: The specified Android SDK Build Tools version (25.0.2) is ignored, as it is below the minimum supported version (28.0.3) for Android Gradle Plugin 3.3.1.
Android SDK Build Tools 28.0.3 will be used.
To suppress this warning, remove "buildToolsVersion '25.0.2'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the
build tools.

> Task :react-native-cookies:compileDebugJavaWithJavac
Note: C:\Users\Mercurius\Documents\GitHub\Yanky-Panky-Mobile\node_modules\react-native-cookies\android\src\main\java\com\psykar\cookiemanager\CookieManagerModule.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

@fortezhuo
Copy link

fortezhuo commented May 25, 2019

For suppress warning build tools 25.0.2, please add following script into /android/build.gradle

subprojects {
    afterEvaluate {project ->
        if (project.hasProperty("android")) {
            android {
                compileSdkVersion 28
                buildToolsVersion '28.0.3'
            }
        }
    }
}

@Noitidart
Copy link

Thanks @hedikasmanto! I'm not on the project right now, but next I use it, I will try this out and let you know.

@johnshroff
Copy link

This fixes the build tools version warning, but not the 'compile' is obsolete warning

@safaiyeh
Copy link

safaiyeh commented Jan 2, 2020

I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store
We can create issues and PRs there to continue the development of the project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants