Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font-size properties #11

Closed
Jwbeev opened this issue Feb 1, 2016 · 6 comments
Closed

Font-size properties #11

Jwbeev opened this issue Feb 1, 2016 · 6 comments

Comments

@Jwbeev
Copy link

Jwbeev commented Feb 1, 2016

Hey there--

Love vunit! But there is a pretty large feature that seems to be missing from it. Why can't I use font-size properties other than just vw? The ability to size text on vh, vmin or vmax would be extremely helpful!! Anytime I try to manually add the properties in my CSSMap, vunit won't load.

Are these features planned to be implemented? Is there just something I'm doing wrong?

Thanks for your help!

@joaocunha
Copy link
Owner

Hey @Jwbeev! Font-sizes are supposed to work just fine with all variants. Can you post the code you're using here?

@Jwbeev
Copy link
Author

Jwbeev commented Feb 4, 2016

Hey there, thanks for the fast response! Actually, I just retyped all my
code again and it works now! Weird...

BUT I do have another question regarding a feature that I know isn't
working. Are you planning to support sizes with decimals? For instance,
using purely CSS I can set the font height at 2.5vh. If I try to do
anything with a decimal using vUnit, it simply does not load. I find that
I need really specific numbers in order for the fonts to scale properly
across all devices.

Thanks!

On Mon, Feb 1, 2016 at 1:17 PM, João Cunha [email protected] wrote:

Hey @Jwbeev https://github.com/Jwbeev! Font-sizes are supposed to work
just fine with all variants. Can you post the code you're using here?


Reply to this email directly or view it on GitHub
#11 (comment).

@joaocunha
Copy link
Owner

@Jwbeev indeed, it is an often requested feature, but it's a tricky problem to solve due to the nature of the library. It screws up performance pretty bad.

See #10 and #3.

@joaocunha joaocunha changed the title font-size properties Font-size properties Feb 4, 2016
@joaocunha
Copy link
Owner

I reopened #3 so we can discuss it over there.

@Jwbeev
Copy link
Author

Jwbeev commented Feb 4, 2016

Ah, I figured that might be the case. That's a tricky one. Hope you find
the solution!

On Thu, Feb 4, 2016 at 1:53 PM, João Cunha [email protected] wrote:

@Jwbeev https://github.com/Jwbeev indeed, it is a feature that is
requested often, but it's a tricky problem to solve due to the nature of
the library. It screws up performance.

See #10 #10 and #3
#3.


Reply to this email directly or view it on GitHub
#11 (comment).

@ghost
Copy link

ghost commented Mar 13, 2016

Just got here from this question and as I read down I was super happy to see that font-sizes are working now and then I read further down and see that decimal font-sizes are not working. From cloud nine to down in the dumps. Starred and watching and fingers crossed this can get resolved. @joaocunha All the best with finding a way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants