-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve generated interface impls #251
Comments
Mostly this needs an audit to see what could be improved, as the code is very old. I added this as a placeholder because we were debating whether to turn the generation off for the --dev flag, which does have a small but measurable impact on startup. Ideally we would not ever turn it off because the non-generated path uses java.lang.Proxy which has perf and behavior problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should have a look at how we are generating the implementations of users' interfaces and see if we can make improvements, based on newer ASM and JDK features:
This code was originally written by Wayne Meissner many years ago, so there should be some good improvements possible.
Note that #249 was discovered because JRuby's faster-starting "dev mode" disables the ASM-based code generation in jnr-ffi, which does have a measurable impact on startup time.
The text was updated successfully, but these errors were encountered: