Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add O_DIRECT #107

Open
tmancill opened this issue Apr 27, 2022 · 4 comments
Open

Add O_DIRECT #107

tmancill opened this issue Apr 27, 2022 · 4 comments

Comments

@tmancill
Copy link

Is there a reason that O_DIRECT couldn't be added to OpenFlags? Would you accept a PR for it?

For my specific use case, I'm getting some Java code ready to run on both x86-64 and aarch64, and it's inconvenient that the (currently hard-coded constant) for O_DIRECT on x86-64 maps to the value of O_DIRECTORY on aarch64.

@headius
Copy link
Member

headius commented Apr 28, 2022

Do it! Any flag can be added because all flags can be queried to know whether they are defined on the current platform, and when we regenerate for the other platforms we will pick it up if it exists!

@headius
Copy link
Member

headius commented Apr 28, 2022

regenerate for the other platforms

Or modify by hand, carefully. 😀

tmancill pushed a commit to tmancill/jnr-constants that referenced this issue May 3, 2022
tmancill pushed a commit to tmancill/jnr-constants that referenced this issue May 3, 2022
@almson
Copy link

almson commented May 12, 2022

@tmancill Also O_LARGEFILE and everything else that's in current fcntl.h so that we don't have to ask again 🥺

@headius
Copy link
Member

headius commented May 12, 2022

Yeah, add anything standard you see and we'll get them generated and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants