Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON and zeroconf ServerConfig structs differ #54

Open
jgarzik opened this issue Jun 24, 2022 · 0 comments
Open

JSON and zeroconf ServerConfig structs differ #54

jgarzik opened this issue Jun 24, 2022 · 0 comments
Labels
bug Something isn't working
Milestone
1.0.0

Comments

@jgarzik
Copy link
Owner

jgarzik commented Jun 24, 2022

In zeroconf mode, ServerConfig struct is used.

In JSON config mode, the following is used,

server_cfg = serde_json::from_str(&cfg_text)?;

This creates problems such as the unintended requirement that the ssl section of the config be present, even if using unencrypted HTTP mode.
@jgarzik jgarzik added the bug Something isn't working label Jun 24, 2022
@jgarzik jgarzik added this to the 1.0.0 milestone Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@jgarzik