Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore Rules cant have policies and watches both #130

Closed
Chirag94 opened this issue Jul 18, 2023 · 2 comments
Closed

Ignore Rules cant have policies and watches both #130

Chirag94 opened this issue Jul 18, 2023 · 2 comments
Assignees
@danielmkn
Labels
bug Something isn't working

Comments

@Chirag94
Copy link

Chirag94 commented Jul 18, 2023 •
edited
Loading

Hey Team,
Right now the ignore rules can be applied on a specific watch and a specific policy. But seems the terraform validator while planning is validating for either of them.
I get a conflict error for them when I supply both.

Re:https://github.com/jfrog/terraform-provider-xray/blob/master/pkg/xray/resource_xray_ignore_rule.go#L132C5-L132C18
Whats the purpose of these?
@Chirag94 Chirag94 added the bug Something isn't working label Jul 18, 2023
@danielmkn
Copy link
Collaborator

danielmkn commented Jul 18, 2023 •
edited
Loading

Hi @Chirag94! The purpose of the ConflictsWith property there is to limit the practitioner to use only one of the "policies" or "watches" attributes.
Our understanding was you can't add both watches and policies to the ignore rule, but I've tested it and it works. We will remove these properties.
Thanks for reporting the issue!

danielmkn added a commit that referenced this issue Jul 18, 2023
@danielmkn
GH-130 allow to create ignore rules for both watches and policies
668d2cf
danielmkn added a commit that referenced this issue Jul 18, 2023
@danielmkn
GH-130 add PR link.
2ea5b2b
danielmkn added a commit that referenced this issue Jul 18, 2023
@danielmkn
GH-130 updated go modules.
4b12dc3
danielmkn added a commit that referenced this issue Jul 18, 2023
@danielmkn
Merge pull request #131 from jfrog/GH-130-ignore-rules
49aa6d3 
GH-130 allow to create ignore rules for both watches and policies
@danielmkn
Copy link
Collaborator

@Chirag94 the fix is released in v1.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmkn danielmkn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chirag94 @danielmkn