From 903262b081c9c0a9194193caf311842122b6e32d Mon Sep 17 00:00:00 2001 From: Jeroen Ooms Date: Fri, 9 Aug 2024 22:28:38 +0200 Subject: [PATCH] Disable a test for new MacOS libcurl --- DESCRIPTION | 2 +- NEWS | 3 +++ tests/testthat/test-connection.R | 2 ++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index c7c388da..d87844c4 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Package: curl Type: Package Title: A Modern and Flexible Web Client for R -Version: 5.2.1 +Version: 5.2.1.9000 Authors@R: c( person("Jeroen", "Ooms", role = c("aut", "cre"), email = "jeroen@berkeley.edu", comment = c(ORCID = "0000-0002-4035-0289")), diff --git a/NEWS b/NEWS index 45aaaa2c..16e6657b 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +5.2.2 + - Disable a compression test for libcurl 8.7.1 which has a bug for deflate + 5.2.1 - In handle_setheader(), setting a header to a non-empty whitespace string will now send a blank header. Using an empty string will still remove the header diff --git a/tests/testthat/test-connection.R b/tests/testthat/test-connection.R index d52fc036..7ec8dceb 100644 --- a/tests/testthat/test-connection.R +++ b/tests/testthat/test-connection.R @@ -3,6 +3,8 @@ context("Connections") h <- new_handle() test_that("Compression and destroying connection", { + # Compression is broken in 8.7.1, see https://github.com/curl/curl/issues/13493 + skip_if(curl::curl_version()$version == '8.7.1') con <- curl(httpbin("deflate"), handle = h) expect_equal(jsonlite::fromJSON(readLines(con))$deflate, TRUE) expect_false(isOpen(con))