-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not find credentials after latest release #180
Comments
Can you check if this incremental was still working? (I'm currently far away from any usable AWS credentials, so I cannot test myself) If this is the case, the bug was most likely introduced with c45fcef and I missed some acegisecurity to spring security migration... |
Thanks for a quick reaction I'll try to check it and give you a feedback then. |
@TobiX I confirm it works properly with the |
I'd rather not revert the change, since it is a future-proving migration. I wrote a simple test case (and documentation how to use it) for the functionality of this plugin in #182, which proves the basic functionality still works... Maybe you could provide a minimal reproducer for your usecase, so we can find what is broken? |
A thing which changed with the modernisation it that DomainRequirements are now passed through when looking up credentials. So if your credential domains are defined too restricted, they will not be found... |
@TobiX Thank you. I see I need to check whether such test is possible in our Jenkins, as we rather do not want to set sensitive data as env variables, could you additionally explain what do you meant by saying
What kind of restriction level? |
Thank you, now clear to me let me check then with changed domain settings |
@TobiX Indeed that was a brilliant remark, we had obsolete domains set there, now after setting them to up to date ones it works like a charm. Thank you for you help. |
@marcingryska Thanks for the confirmation. Maybe this needs a documentation update... Feel free to close this issue if the issue is fixed for you! |
Jenkins and plugins versions report
Environment
What Operating System are you using (both controller, and any agents involved in the problem)?
Debian
Reproduction steps
A command used to work properly with previous version i.e 1.114.vfd22430621f5:
now (version of 1.136.v914ea_5948634) it produces exception of not found credentials.
Expected Results
push to ECR successful
Actual Results
Exception occurs:
hudson.AbortException: Could not find credentials matching credentials:here
The text was updated successfully, but these errors were encountered: