Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for discovery ports #970

Open
fice-t opened this issue Apr 26, 2024 · 1 comment
Open

Improve documentation for discovery ports #970

fice-t opened this issue Apr 26, 2024 · 1 comment

Comments

@fice-t
Copy link

fice-t commented Apr 26, 2024

On the Networking page:

  1. Service Discovery states that DLNA also uses port 1900:

DLNA also uses this port

What else, relevant to Jellyfin, uses port 1900? A quick search for 1900 in the Jellyfin org only yielded the DLNA plugin using this port. The "also" should be removed if nothing else uses the port, otherwise there should be a mention of other users of the port. If it is only for general UPnP, then perhaps UPnP should be mentioned?

  1. Client Discovery heading states the UDP protocol explicitly, while Service Discovery, which also uses UDP, does not. Perhaps the Service Discovery and HTTP(S) sections should explicitly state the protocols in their headers as well?

  2. DLNA here should link to the DLNA subpage, which in turn could link to some external site which describes what DLNA actually is.

  3. I found the wording in the discovery sections a bit confusing. Both Service Discovery and Client Discovery both talk about client discovery. It would be nice if it clearly differentiated the usage of each port.

@felix920506
Copy link
Member

If you already know how to fix the errors you mentioned, please open a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants