Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase category/tag names #351

Open
bbatsov opened this issue Nov 13, 2021 · 3 comments
Open

Lowercase category/tag names #351

bbatsov opened this issue Nov 13, 2021 · 3 comments
Labels

Comments

@bbatsov
Copy link

bbatsov commented Nov 13, 2021

With the following config:

feed:
  path: atom.xml
  categories:
    - Emacs

the feed for the category Emacs, ends up being named feed/Emacs.xml instead of feed/emacs.xml. I took me a while to figure this out as I expected that the feed would named feed/emacs.xml, but trying to access it resulted in a 404. As capitalized names are uncommon in URLs, I think it makes sense to just lowercase category names.

The same problem exists for tag feeds.

@ashmaroli
Copy link
Member

As capitalized names are uncommon in URLs,

To maintain backwards-compatibility, I think the best route would be to support a new configuration:

feed:
  lowercased_feed_url: true   # false by default

@bbatsov
Copy link
Author

bbatsov commented Nov 14, 2021

Yeah, that makes perfect sense.

@bbatsov bbatsov changed the title Lowercase category names Lowercase category/tag names Nov 15, 2021
@bbatsov
Copy link
Author

bbatsov commented Jan 15, 2022

The issue is still relevant.

@jekyllbot jekyllbot removed the stale label Jan 15, 2022
@ashmaroli ashmaroli removed the stale label Mar 15, 2022
@parkr parkr added pinned and removed stale labels May 17, 2022
@jekyll jekyll deleted a comment from jekyllbot May 17, 2022
@jekyll jekyll deleted a comment from jekyllbot May 17, 2022
@jekyll jekyll deleted a comment from jekyllbot May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants